Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTextFragment.h

Issue 1414393003: Rename LayoutTextFragment::m_end to m_length (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutTextFragment.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutTextFragment.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutTextFragment.h b/third_party/WebKit/Source/core/layout/LayoutTextFragment.h
index fe4c6f56fd7b75bfc69c92221d8baea1c4c3c121..c9126f52febe63c8a69eb8bafa14b28a664291fd 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTextFragment.h
+++ b/third_party/WebKit/Source/core/layout/LayoutTextFragment.h
@@ -44,7 +44,7 @@ public:
bool canBeSelectionLeaf() const override { return node() && node()->hasEditableStyle(); }
unsigned start() const { return m_start; }
- unsigned end() const { return m_end; }
+ unsigned fragmentLength() const { return m_length; }
dsinclair 2015/10/26 13:19:34 This should probably be m_fragmentLength to be con
dsinclair 2015/10/26 13:19:34 Is this never called outside this class? Can we ma
Srirama 2015/10/26 13:40:30 Done.
Srirama 2015/10/26 13:40:30 This is not called outside, though start() is used
unsigned textStartOffset() const override { return start(); }
@@ -83,7 +83,7 @@ private:
void updateHitTestResult(HitTestResult&, const LayoutPoint&) override;
unsigned m_start;
- unsigned m_end;
+ unsigned m_length;
bool m_isRemainingTextLayoutObject;
RefPtr<StringImpl> m_contentString;
// Reference back to FirstLetterPseudoElement; cleared by FirstLetterPseudoElement::detach() if
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutTextFragment.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698