Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2672)

Issue 1414393003: Rename LayoutTextFragment::m_end to m_length (Closed)

Created:
5 years, 2 months ago by Srirama
Modified:
5 years, 1 month ago
Reviewers:
dsinclair, yosin_UTC9
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename LayoutTextFragment::m_end to m_fragmentLength BUG=545789 Committed: https://crrev.com/0ce9458242f0ee218df05102c71f3d443671369e Cr-Commit-Position: refs/heads/master@{#356050}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address comments #

Total comments: 4

Patch Set 3 : rename m_length to m_fragmentLength #

Patch Set 4 : make fragmentLength() private #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutTextFragment.h View 1 2 3 2 chunks +2 lines, -2 lines 1 comment Download
M third_party/WebKit/Source/core/layout/LayoutTextFragment.cpp View 1 2 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (6 generated)
Srirama
PTAL. There is a conflict with the function name "length" in LayoutText.h, so i made ...
5 years, 2 months ago (2015-10-22 06:54:58 UTC) #3
yosin_UTC9
Thanks for working this! I've been confusing so far. +dsinclair@ in layout team. https://codereview.chromium.org/1414393003/diff/1/third_party/WebKit/Source/core/layout/LayoutTextFragment.h File ...
5 years, 2 months ago (2015-10-22 07:23:16 UTC) #5
dsinclair
https://codereview.chromium.org/1414393003/diff/1/third_party/WebKit/Source/core/layout/LayoutTextFragment.h File third_party/WebKit/Source/core/layout/LayoutTextFragment.h (right): https://codereview.chromium.org/1414393003/diff/1/third_party/WebKit/Source/core/layout/LayoutTextFragment.h#newcode47 third_party/WebKit/Source/core/layout/LayoutTextFragment.h:47: unsigned fragLength() const { return m_length; } On 2015/10/22 ...
5 years, 2 months ago (2015-10-22 13:04:50 UTC) #6
Srirama
Thanks for the review. PTAL. https://codereview.chromium.org/1414393003/diff/1/third_party/WebKit/Source/core/layout/LayoutTextFragment.h File third_party/WebKit/Source/core/layout/LayoutTextFragment.h (right): https://codereview.chromium.org/1414393003/diff/1/third_party/WebKit/Source/core/layout/LayoutTextFragment.h#newcode47 third_party/WebKit/Source/core/layout/LayoutTextFragment.h:47: unsigned fragLength() const { ...
5 years, 2 months ago (2015-10-22 13:47:59 UTC) #7
yosin_UTC9
lgtm Since, I'm not OWNER of core/layout/, please wait OWNER's lgtm.
5 years, 2 months ago (2015-10-23 05:47:36 UTC) #8
dsinclair
https://codereview.chromium.org/1414393003/diff/20001/third_party/WebKit/Source/core/layout/LayoutTextFragment.h File third_party/WebKit/Source/core/layout/LayoutTextFragment.h (right): https://codereview.chromium.org/1414393003/diff/20001/third_party/WebKit/Source/core/layout/LayoutTextFragment.h#newcode47 third_party/WebKit/Source/core/layout/LayoutTextFragment.h:47: unsigned fragmentLength() const { return m_length; } This should ...
5 years, 1 month ago (2015-10-26 13:19:35 UTC) #9
Srirama
https://codereview.chromium.org/1414393003/diff/20001/third_party/WebKit/Source/core/layout/LayoutTextFragment.h File third_party/WebKit/Source/core/layout/LayoutTextFragment.h (right): https://codereview.chromium.org/1414393003/diff/20001/third_party/WebKit/Source/core/layout/LayoutTextFragment.h#newcode47 third_party/WebKit/Source/core/layout/LayoutTextFragment.h:47: unsigned fragmentLength() const { return m_length; } On 2015/10/26 ...
5 years, 1 month ago (2015-10-26 13:40:30 UTC) #10
dsinclair
On 2015/10/26 13:40:30, Srirama wrote: > third_party/WebKit/Source/core/layout/LayoutTextFragment.h:47: unsigned > fragmentLength() const { return m_length; } ...
5 years, 1 month ago (2015-10-26 13:41:16 UTC) #12
Srirama
On 2015/10/26 13:41:16, dsinclair wrote: > On 2015/10/26 13:40:30, Srirama wrote: > > third_party/WebKit/Source/core/layout/LayoutTextFragment.h:47: unsigned ...
5 years, 1 month ago (2015-10-26 13:44:47 UTC) #13
dsinclair
lgtm
5 years, 1 month ago (2015-10-26 13:46:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414393003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414393003/60001
5 years, 1 month ago (2015-10-26 13:46:21 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-10-26 14:59:03 UTC) #18
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/0ce9458242f0ee218df05102c71f3d443671369e Cr-Commit-Position: refs/heads/master@{#356050}
5 years, 1 month ago (2015-10-26 14:59:53 UTC) #19
yosin_UTC9
5 years, 1 month ago (2015-10-27 01:06:52 UTC) #20
Message was sent while issue was closed.
https://codereview.chromium.org/1414393003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutTextFragment.h (right):

https://codereview.chromium.org/1414393003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutTextFragment.h:83: unsigned
fragmentLength() const { return m_fragmentLength; }
Oops, I'm a first user of using |fragmentLength()|.

http://crrev.com/1404423005 is an example.

Powered by Google App Engine
This is Rietveld 408576698