Issue 1414353006: Define measurements as a tuple of name and spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1414353006: Define measurements as a tuple of name and spec. (Closed)

Created:
5 years, 1 month ago by ppi

Modified:
5 years, 1 month ago

Reviewers:
etiennej, qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Define measurements as a tuple of name and spec. Measurements specs are lengthy. This patch gives each measurement a name which is used for display purposes and for labeling the data uploaded to perf dashboard. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/077e43dc6ec22a87fb2f26db2894196c47e5250d

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -52 lines)			Patch
M	mojo/devtools/common/mojo_benchmark	View	5 chunks	+32 lines, -15 lines	0 comments	Download
M	mojo/tools/data/benchmarks	View	3 chunks	+20 lines, -5 lines	0 comments	Download
M	mojo/tools/data/rtt_benchmarks	View	8 chunks	+32 lines, -32 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ppi

5 years, 1 month ago (2015-10-28 10:04:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
077e43dc6ec22a87fb2f26db2894196c47e5250d (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages