src/IceTargetLoweringX86BaseImpl.h - Issue 1414343010: Sort allocas, compute frame pointer in Cfg pass

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX86BaseImpl.h

Issue 1414343010: Sort allocas, compute frame pointer in Cfg pass (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review fixes Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringX86BaseImpl.h

diff --git a/src/IceTargetLoweringX86BaseImpl.h b/src/IceTargetLoweringX86BaseImpl.h

index 2ecb7d3b688722361ea4de4a905e0dfdcab4364a..b22ec6441ec82ba6e7f41bb2b401e7b10961344e 100644

--- a/src/IceTargetLoweringX86BaseImpl.h

+++ b/src/IceTargetLoweringX86BaseImpl.h

@@ -957,7 +957,6 @@ void TargetX86Base<Machine>::lowerAlloca(const InstAlloca *Inst) {

uint32_t Alignment =

std::max(AlignmentParam, Traits::X86_STACK_ALIGNMENT_BYTES);

if (Alignment > Traits::X86_STACK_ALIGNMENT_BYTES) {

- IsEbpBasedFrame = true;

_and(esp, Ctx->getConstantInt32(-Alignment));

}

if (const auto *ConstantTotalSize =

« no previous file with comments | « src/IceTargetLoweringX86Base.h ('k') | no next file » | no next file with comments »