[Extensions] Fix hiding browser actions without the toolbar redesign

[Extensions] Fix hiding browser actions without the toolbar redesign

Hiding actions without the toolbar redesign means removing them entirely, so if
they exist in the toolbar, they are considered 'visible' (even if they are in
the chevron).

BUG=544859
BUG=548160
Committed: https://crrev.com/c89130e28fd01062104e1be7f3a6fc3abbb80ca9
Cr-Commit-Position: refs/heads/master@{#356400}

[Devlin, 2015-10-22 17:15:14]

Patchset #1 (id:1) has been deleted

[Devlin, 2015-10-22 17:15:20]

Patchset #1 (id:20001) has been deleted

[Devlin, 2015-10-22 17:15:24]

Patchset #1 (id:40001) has been deleted

[Devlin, 2015-10-22 17:17:13]

Description was changed from

==========
[Extensions] Fix
BUG=
==========

to

==========
[Extensions] Fix hiding browser actions without the toolbar redesign

Hiding actions without the toolbar redesign means removing them entirely, so if
they exist in the toolbar, they are considered 'visible' (even if they are in
the chevron).

BUG=544859
==========

[Devlin, 2015-10-22 17:17:13]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org

[Devlin, 2015-10-22 17:17:40]

Finnur, mind taking a quick look?

[Finnur, 2015-10-23 11:42:38]

LGTM

[Devlin, 2015-10-27 21:04:51]

Description was changed from

==========
[Extensions] Fix hiding browser actions without the toolbar redesign

Hiding actions without the toolbar redesign means removing them entirely, so if
they exist in the toolbar, they are considered 'visible' (even if they are in
the chevron).

BUG=544859
==========

to

==========
[Extensions] Fix hiding browser actions without the toolbar redesign

Hiding actions without the toolbar redesign means removing them entirely, so if
they exist in the toolbar, they are considered 'visible' (even if they are in
the chevron).

BUG=544859
BUG=548160
==========

[Devlin, 2015-10-27 21:15:02]

https://codereview.chromium.org/1414343003/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/toolbar/chevron_menu_button.cc (right):

https://codereview.chromium.org/1414343003/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/chevron_menu_button.cc:215:
icon_updaters_.clear();
Note: added this so that updaters were cleared when the menu's closed, since it
might be closed as a part of removing an action.

[Devlin, 2015-10-27 21:15:06]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-10-27 21:15:07]

The patchset sent to the CQ was uploaded after l-g-t-m from finnur@chromium.org
Link to the patchset: https://codereview.chromium.org/1414343003/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-10-27 21:16:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1414343003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1414343003/80001

[commit-bot: I haz the power, 2015-10-27 21:25:00]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2015-10-27 21:26:40]

Patchset 2 (id:??) landed as
https://crrev.com/c89130e28fd01062104e1be7f3a6fc3abbb80ca9
Cr-Commit-Position: refs/heads/master@{#356400}