Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1414333014: Queueing fix, cleanups. (Closed)

Created:
5 years, 1 month ago by srdjan
Modified:
5 years ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : d #

Total comments: 2

Patch Set 3 : d #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -23 lines) Patch
M runtime/vm/compiler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/compiler.cc View 1 2 5 chunks +22 lines, -21 lines 1 comment Download
M runtime/vm/object.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
srdjan
5 years, 1 month ago (2015-11-06 17:16:40 UTC) #2
siva
lgtm https://codereview.chromium.org/1414333014/diff/20001/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/1414333014/diff/20001/runtime/vm/compiler.cc#newcode1498 runtime/vm/compiler.cc:1498: } This is not used anymore, can be ...
5 years, 1 month ago (2015-11-06 23:12:54 UTC) #3
srdjan
Committed patchset #3 (id:40001) manually as fa3c4850016e9cec2a11d8b90a1288da14f00990 (presubmit successful).
5 years, 1 month ago (2015-11-06 23:20:11 UTC) #4
rmacnak
https://codereview.chromium.org/1414333014/diff/40001/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/1414333014/diff/40001/runtime/vm/compiler.cc#newcode1141 runtime/vm/compiler.cc:1141: ASSERT(!optimized); Precompiled code can have compile-time errors too
5 years, 1 month ago (2015-11-09 22:00:02 UTC) #6
srdjan
5 years ago (2015-12-09 22:43:17 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1414333014/diff/20001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1414333014/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1498: }
On 2015/11/06 23:12:54, siva wrote:
> This is not used anymore, can be removed?

Done.

Powered by Google App Engine
This is Rietveld 408576698