Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: pkg/compiler/lib/src/cps_ir/type_propagation.dart

Issue 1414333008: dart2js cps: Do not inline static async methods. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/language_dart2js.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/type_propagation.dart
diff --git a/pkg/compiler/lib/src/cps_ir/type_propagation.dart b/pkg/compiler/lib/src/cps_ir/type_propagation.dart
index b583dc49a4e828f7755580d2ce047abb7888cf18..493201f397869d45228db117788fbe6399bf04c4 100644
--- a/pkg/compiler/lib/src/cps_ir/type_propagation.dart
+++ b/pkg/compiler/lib/src/cps_ir/type_propagation.dart
@@ -1878,6 +1878,11 @@ class TransformingVisitor extends DeepRecursiveVisitor {
// The target might not have an AST, for example if it deferred.
if (!node.target.hasNode) return false;
+ if (node.target.asyncMarker != AsyncMarker.SYNC) {
+ // Inlining of async/sync*/async* methods is currently not supported.
+ return false;
+ }
+
// True if an expression is non-expansive, in the sense defined by this
// predicate.
bool isNonExpansive(ast.Expression expr) {
« no previous file with comments | « no previous file | tests/language/language_dart2js.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698