Source/core/html/canvas/CanvasRenderingContext2D.h - Issue 141433026: Font metrics, version 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/CanvasRenderingContext2D.h

Issue 141433026: Font metrics, version 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Adding Layout tests. Should work for simple text. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/canvas/CanvasRenderingContext2D.h

diff --git a/Source/core/html/canvas/CanvasRenderingContext2D.h b/Source/core/html/canvas/CanvasRenderingContext2D.h

index bdf59141b43073c74451b7947e36a0f7577562ec..67d6b2c482114e9d53161b1253ac38658bfdea55 100644

--- a/Source/core/html/canvas/CanvasRenderingContext2D.h

+++ b/Source/core/html/canvas/CanvasRenderingContext2D.h

@@ -311,6 +311,7 @@ private:

void drawTextInternal(const String& text, float x, float y, bool fill, float maxWidth = 0, bool useMaxWidth = false);

const Font& accessFont();

+ int getFontBaseline(const FontMetrics&) const;

void clearCanvas();

bool rectContainsTransformedRect(const FloatRect&, const FloatRect&) const;