Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 141433025: Remove BOM from SkFontHost_FreeType.cpp. (Closed)

Created:
6 years, 10 months ago by bungeman-skia
Modified:
6 years, 10 months ago
Reviewers:
rmistry
CC:
skia-review_googlegroups.com, zheng.xu
Visibility:
Public.

Description

Remove BOM from SkFontHost_FreeType.cpp. With r12822 a UTF-8 BOM was added to SkFontHost_FreeType.cpp. This change removes it. Running find . -type f \( -name '*.cpp' -o -name '*.h' \) -exec file {} \; | grep BOM makes it look like this is the only file with a UTF-8 BOM at this time. The BOM is easily removed with tail -c +4 <filename> R=rmistry@google.com Committed: https://code.google.com/p/skia/source/detail?r=13225

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
src/ports/SkFontHost_FreeType.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
bungeman-skia
We don't want UTF-8 BOM in source files. I actually 1gtm'ed the original CL, but ...
6 years, 10 months ago (2014-01-28 18:12:16 UTC) #1
rmistry
LGTM
6 years, 10 months ago (2014-01-28 20:07:37 UTC) #2
bungeman-skia
6 years, 10 months ago (2014-01-28 20:33:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r13225.

Powered by Google App Engine
This is Rietveld 408576698