Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/re2/BUILD.gn

Issue 141433015: GN build fixes, mostly for Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: put back sha1 file Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/compiler/BUILD.gn ('K') | « build/config/sysroot.gni ('k') | tools/gn/gyp_binary_target_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/re2/BUILD.gn
diff --git a/third_party/re2/BUILD.gn b/third_party/re2/BUILD.gn
index 67b43784f9f96d4eb292bf8379d3d8c4e9e1fdc7..125904895b1638cbb617265e187508eca98b8987 100644
--- a/third_party/re2/BUILD.gn
+++ b/third_party/re2/BUILD.gn
@@ -71,7 +71,10 @@ static_library("re2") {
if (is_win) {
include_dirs = [ "mswin" ]
- # TODO(brettw) 'msvs_disabled_warnings': [ 4018, 4722, 4267 ],
+ cflags = [
+ "/wd4267", # Conversion from size_t.
+ "/wd4722", # Destructor never terminates.
+ ]
} else {
sources -= [ "mswin/stdint.h" ]
}
« build/config/compiler/BUILD.gn ('K') | « build/config/sysroot.gni ('k') | tools/gn/gyp_binary_target_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698