Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Side by Side Diff: third_party/re2/BUILD.gn

Issue 141433015: GN build fixes, mostly for Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: put back sha1 file Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # TODO(brettw) use this value when we remove external=true below. 5 # TODO(brettw) use this value when we remove external=true below.
6 #gyp_file = "//$gyp_output_dir/gn_gyp/third_party/re2/re2.gyp" 6 #gyp_file = "//$gyp_output_dir/gn_gyp/third_party/re2/re2.gyp"
7 7
8 config("re2_config") { 8 config("re2_config") {
9 include_dirs = [ "." ] 9 include_dirs = [ "." ]
10 } 10 }
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 configs -= [ "//build/config/compiler:chromium_code" ] 64 configs -= [ "//build/config/compiler:chromium_code" ]
65 configs += [ "//build/config/compiler:no_chromium_code" ] 65 configs += [ "//build/config/compiler:no_chromium_code" ]
66 direct_dependent_configs = [ ":re2_config" ] 66 direct_dependent_configs = [ ":re2_config" ]
67 67
68 deps = [ 68 deps = [
69 "//base/third_party/dynamic_annotations", 69 "//base/third_party/dynamic_annotations",
70 ] 70 ]
71 71
72 if (is_win) { 72 if (is_win) {
73 include_dirs = [ "mswin" ] 73 include_dirs = [ "mswin" ]
74 # TODO(brettw) 'msvs_disabled_warnings': [ 4018, 4722, 4267 ], 74 cflags = [
75 "/wd4267", # Conversion from size_t.
76 "/wd4722", # Destructor never terminates.
77 ]
75 } else { 78 } else {
76 sources -= [ "mswin/stdint.h" ] 79 sources -= [ "mswin/stdint.h" ]
77 } 80 }
78 } 81 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698