Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1439)

Unified Diff: chrome/browser/feedback/feedback_uploader_unittest.cc

Issue 141433011: Cache feedback reports to disk in case of send failure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/feedback/feedback_uploader_unittest.cc
diff --git a/chrome/browser/feedback/feedback_uploader_unittest.cc b/chrome/browser/feedback/feedback_uploader_unittest.cc
index 407a286c0e3fc347f3398ad0d63f7011792e7bc3..917e0b10e5555286418e6b6b54dac235b5a9882c 100644
--- a/chrome/browser/feedback/feedback_uploader_unittest.cc
+++ b/chrome/browser/feedback/feedback_uploader_unittest.cc
@@ -54,15 +54,15 @@ class FeedbackUploaderTest : public testing::Test {
}
void QueueReport(const std::string& data) {
- uploader_->QueueReport(make_scoped_ptr(new std::string(data)));
+ uploader_->QueueReport(data);
}
void ReportFailure(const std::string& data) {
- uploader_->RetryReport(make_scoped_ptr(new std::string(data)));
+ uploader_->RetryReport(data);
}
- void MockDispatchReport(scoped_ptr<std::string> report_data) {
- dispatched_reports_.push_back(*report_data.get());
+ void MockDispatchReport(const std::string& report_data) {
+ dispatched_reports_.push_back(report_data);
// Dispatch will always update the timer, whether successful or not,
// simulate the same behavior.

Powered by Google App Engine
This is Rietveld 408576698