Cache feedback reports to disk in case of send failure.

chrome/browser/chrome_browser_main.cc

Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index df7f182ac188ac5731c30bb6a5bbd33551fde864..6490b81b5d340fed038a92eccc42247a191f49d4 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -56,6 +56,7 @@
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/startup_helper.h"
+#include "chrome/browser/feedback/feedback_profile_observer.h"
 #include "chrome/browser/first_run/first_run.h"
 #include "chrome/browser/first_run/upgrade_util.h"
 #include "chrome/browser/google/google_search_counter.h"
@@ -1230,6 +1231,10 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
 #endif  // defined(OS_WIN)
   }
 
+  // Initialize the feedback uploader so it can setup notifications for profile
+  // creation.
+  feedback::FeedbackProfileObserver::Initialize();

[Lei Zhang, 2014/01/23 22:40:59]

Can do this in PreProfileInit() instead? Up near line 1050.

[rkc, 2014/01/23 22:57:21]

I am a little concerned about moving it that late. The comment near
PreProfileInit mentions that the profile creation is done in that step; I
specially wanted to be before that step.

Also, the comment right below (// Profile Creation) made it seem like this would
be the perfect place to initialize this observer.

[Lei Zhang, 2014/01/23 23:50:39]

PreProfileInit() is called earlier on line 1201 before the current location. The
"diagram" near line 1012 should show you what the process is like.

[rkc, 2014/01/23 23:56:59]

Done.

+
   // Profile creation ----------------------------------------------------------
 
   MetricsService::SetExecutionPhase(MetricsService::CREATE_PROFILE);