Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: chrome/browser/feedback/feedback_uploader_delegate.h

Issue 141433011: Cache feedback reports to disk in case of send failure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/feedback/feedback_uploader.cc ('k') | chrome/browser/feedback/feedback_uploader_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/feedback/feedback_uploader_delegate.h
diff --git a/chrome/browser/feedback/feedback_uploader_delegate.h b/chrome/browser/feedback/feedback_uploader_delegate.h
index 5da18dd62c4a399a17e4c5f2fe7b8c12e3502fe2..b50010425ab824bb48b028d075d2a3851b29db5e 100644
--- a/chrome/browser/feedback/feedback_uploader_delegate.h
+++ b/chrome/browser/feedback/feedback_uploader_delegate.h
@@ -9,19 +9,18 @@
#include "base/basictypes.h"
#include "base/callback.h"
-#include "base/memory/scoped_ptr.h"
#include "net/url_request/url_fetcher_delegate.h"
namespace feedback {
-typedef base::Callback<void(scoped_ptr<std::string>)> ReportDataCallback;
+typedef base::Callback<void(const std::string&)> ReportDataCallback;
// FeedbackUploaderDelegate is a simple http uploader for a feedback report. On
// succes or failure, it deletes itself, but on failure it also notifies the
// error callback specified when constructing the class instance.
class FeedbackUploaderDelegate : public net::URLFetcherDelegate {
public:
- FeedbackUploaderDelegate(scoped_ptr<std::string> post_body,
+ FeedbackUploaderDelegate(const std::string& post_body,
const base::Closure& success_callback,
const ReportDataCallback& error_callback);
virtual ~FeedbackUploaderDelegate();
@@ -30,7 +29,7 @@ class FeedbackUploaderDelegate : public net::URLFetcherDelegate {
// Overridden from net::URLFetcherDelegate.
virtual void OnURLFetchComplete(const net::URLFetcher* source) OVERRIDE;
- scoped_ptr<std::string> post_body_;
+ std::string post_body_;
base::Closure success_callback_;
ReportDataCallback error_callback_;
« no previous file with comments | « chrome/browser/feedback/feedback_uploader.cc ('k') | chrome/browser/feedback/feedback_uploader_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698