Cache feedback reports to disk in case of send failure.

chrome/browser/feedback/feedback_report.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.

[Zachary Kuznia, 2014/01/23 05:21:01]

2014

[rkc, 2014/01/23 21:48:00]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/feedback/feedback_report.h"
+
+#include "base/file_util.h"
+#include "base/files/file_enumerator.h"
+#include "base/files/important_file_writer.h"
+#include "base/strings/string_number_conversions.h"
+#include "content/public/browser/browser_context.h"
+#include "content/public/browser/browser_thread.h"
+#include "net/base/directory_lister.h"
+
+using content::BrowserThread;
+
+namespace {
+
+const base::FilePath::CharType kFeedbackReportPath[] =
+    FILE_PATH_LITERAL("Feedback Reports");
+const base::FilePath::CharType kFeedbackReportFilenameWildcard[] =
+    FILE_PATH_LITERAL("Feedback Report.*");
+
+const char kFeedbackReportFilenamePrefix[] = "Feedback Report.";
+
+base::FilePath GetFeedbackReportsPath(content::BrowserContext* context) {
+  return context->GetPath().Append(kFeedbackReportPath);
+}
+
+// We need this function to post a task to delete file (which returns a bool
+// causing Bind to fail compile).
+void DeleteFileNoReturn(base::FilePath file, bool recursive) {
+  base::DeleteFile(file, recursive);
+}
+
+}  // namespace
+
+namespace feedback {
+
+FeedbackReport::FeedbackReport(
+    content::BrowserContext* context,
+    const base::Time& upload_at,
+    const std::string& data) : context_(context),
+                                    upload_at_(upload_at),

[Zachary Kuznia, 2014/01/23 05:21:01]

nit: indent

[rkc, 2014/01/23 21:48:00]

Done.

+                                    data_(data) {
+  base::FilePath reports_path = GetFeedbackReportsPath(context);
+  if (reports_path.empty())
+    return;
+
+  std::string upload_time = base::Int64ToString(upload_at.ToInternalValue());

[Zachary Kuznia, 2014/01/23 05:21:01]

Is there a reason to use the upload time, like to make sure that reports from
the same time hash to the same filename?  If not, maybe use a GUID instead?

[rkc, 2014/01/23 21:48:00]

It's unique and it can help in diagnosing issues, since the reportfilename1 <
reportfilename2 will always mean that report 1 was queued for sending before
report 2.

+  file_ = reports_path.AppendASCII(
+      kFeedbackReportFilenamePrefix + upload_time);
+  content::BrowserThread::PostBlockingPoolTask(
+      FROM_HERE, base::Bind(
+          &FeedbackReport::WriteReportOnBlockingPool, this));
+}
+
+FeedbackReport::~FeedbackReport() {}
+
+void FeedbackReport::DeleteReportOnDisk() {
+  content::BrowserThread::PostBlockingPoolTask(
+      FROM_HERE, base::Bind(
+          &DeleteFileNoReturn, file_, false));
+  file_.clear();
+}
+
+void FeedbackReport::WriteReportOnBlockingPool() {
+  base::FilePath reports_path = GetFeedbackReportsPath(context_);
+  if (!base::DirectoryExists(reports_path)) {
+    base::File::Error error;
+    if (!base::CreateDirectoryAndGetError(reports_path, &error))
+      return;
+  }
+  if (!file_.empty())
+    base::ImportantFileWriter::WriteFileAtomically(file_, data_);
+}
+
+// static
+void FeedbackReport::LoadReportsAndQueue(
+    content::BrowserContext* context, QueueCallback callback) {
+  base::FilePath reports_path = GetFeedbackReportsPath(context);
+  if (reports_path.empty())
+    return;
+
+  base::FileEnumerator enumerator(reports_path,
+                                  false,
+                                  base::FileEnumerator::FILES,
+                                  kFeedbackReportFilenameWildcard);
+  for (base::FilePath name = enumerator.Next();
+      !name.empty();

[Zachary Kuznia, 2014/01/23 05:21:01]

nit: indent.

[rkc, 2014/01/23 21:48:00]

Done.

+      name = enumerator.Next()) {
+    std::string data;
+    if (ReadFileToString(name, &data)) {
+      content::BrowserThread::PostTask(
+          BrowserThread::UI,
+          FROM_HERE,
+          base::Bind(callback, data));
+    }
+    base::DeleteFile(name, false);
+  }
+}
+
+}  // namespace feedback