net/http/http_auth_handler_negotiate.cc - Issue 1414313002: Allow dynamic updating of authentication policies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_handler_negotiate.cc

Issue 1414313002: Allow dynamic updating of authentication policies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix various build problems detected on bots. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_auth_handler_negotiate.cc

diff --git a/net/http/http_auth_handler_negotiate.cc b/net/http/http_auth_handler_negotiate.cc

index 3262767ef1cc12fbad183af41d44c7daed802a10..cbcd8e9e8ee593941698465f34eb3bcc318f974e 100644

--- a/net/http/http_auth_handler_negotiate.cc

+++ b/net/http/http_auth_handler_negotiate.cc

@@ -61,7 +61,8 @@ int HttpAuthHandlerNegotiate::Factory::CreateAuthHandler(

url_security_manager(), resolver_,

disable_cname_lookup_, use_port_));

#elif defined(OS_ANDROID)

- if (is_unsupported_ || auth_library_->empty() || reason == CREATE_PREEMPTIVE)

+ if (is_unsupported_ || !auth_library_ || auth_library_->empty() ||

+ reason == CREATE_PREEMPTIVE)

return ERR_UNSUPPORTED_AUTH_SCHEME;

// TODO(cbentzel): Move towards model of parsing in the factory

// method and only constructing when valid.