net/http/http_auth_handler_basic.cc - Issue 1414313002: Allow dynamic updating of authentication policies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_handler_basic.cc

Issue 1414313002: Allow dynamic updating of authentication policies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Handle conflicting Android Webview change Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_auth_handler_basic.cc

diff --git a/net/http/http_auth_handler_basic.cc b/net/http/http_auth_handler_basic.cc

index 27b892bb016b2670266a0c7c6ce40fd1e95cb41a..45367857297c8a488bc8a191d6b50d5971862afc 100644

--- a/net/http/http_auth_handler_basic.cc

+++ b/net/http/http_auth_handler_basic.cc

@@ -13,6 +13,7 @@

#include "net/base/net_string_util.h"

#include "net/http/http_auth.h"

#include "net/http/http_auth_challenge_tokenizer.h"

+#include "net/http/http_auth_scheme.h"

namespace net {

@@ -62,7 +63,7 @@ bool HttpAuthHandlerBasic::Init(HttpAuthChallengeTokenizer* challenge) {

bool HttpAuthHandlerBasic::ParseChallenge(

HttpAuthChallengeTokenizer* challenge) {

// Verify the challenge's auth-scheme.

- if (!base::LowerCaseEqualsASCII(challenge->scheme(), "basic"))

+ if (!base::LowerCaseEqualsASCII(challenge->scheme(), kBasicAuthScheme))

return false;

std::string realm;