Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: net/http/http_auth_handler_negotiate_unittest.cc

Issue 1414313002: Allow dynamic updating of authentication policies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix NET_EXPORTS Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_auth_handler_negotiate_unittest.cc
diff --git a/net/http/http_auth_handler_negotiate_unittest.cc b/net/http/http_auth_handler_negotiate_unittest.cc
index 49ebdad62adb5173e02d99f1bd679bcb662e4cad..3b45bcecab6f578bbe76f4d178a1bef3829ff798 100644
--- a/net/http/http_auth_handler_negotiate_unittest.cc
+++ b/net/http/http_auth_handler_negotiate_unittest.cc
@@ -45,13 +45,13 @@ class HttpAuthHandlerNegotiateTest : public PlatformTest {
factory_.reset(new HttpAuthHandlerNegotiate::Factory());
factory_->set_url_security_manager(url_security_manager_.get());
#if defined(OS_ANDROID)
- std::string* authenticator =
- new std::string("org.chromium.test.DummySpnegoAuthenticator");
- factory_->set_library(authenticator);
+ scoped_ptr<std::string> authenticator(
+ new std::string("org.chromium.test.DummySpnegoAuthenticator"));
+ factory_->set_library(authenticator.Pass());
MockAuthLibrary::EnsureTestAccountExists();
#endif
#if defined(OS_WIN) || (defined(OS_POSIX) && !defined(OS_ANDROID))
- factory_->set_library(auth_library_);
+ factory_->set_library(make_scoped_ptr(auth_library_));
#endif
factory_->set_host_resolver(resolver_.get());
}
@@ -194,8 +194,8 @@ class HttpAuthHandlerNegotiateTest : public PlatformTest {
bool synchronous_resolve_mode,
const std::string& url_string,
scoped_ptr<HttpAuthHandlerNegotiate>* handler) {
- factory_->set_disable_cname_lookup(disable_cname_lookup);
- factory_->set_use_port(use_port);
+ factory_->SetNegotiateDisableCnameLookup(disable_cname_lookup);
+ factory_->SetNegotiateEnablePort(use_port);
resolver_->set_synchronous_mode(synchronous_resolve_mode);
GURL gurl(url_string);
@@ -224,7 +224,9 @@ class HttpAuthHandlerNegotiateTest : public PlatformTest {
#if defined(OS_WIN)
scoped_ptr<SecPkgInfoW> security_package_;
#endif
- // |auth_library_| is passed to |factory_|, which assumes ownership of it.
+ // |auth_library_| is passed to |factory_|, which assumes ownership of it, but
+ // can't be a scoped pointer to it since the tests need access when they set
+ // up the mocks after passing ownership.
MockAuthLibrary* auth_library_;
scoped_ptr<MockHostResolver> resolver_;
scoped_ptr<URLSecurityManager> url_security_manager_;
@@ -363,10 +365,10 @@ TEST_F(HttpAuthHandlerNegotiateTest, MissingGSSAPI) {
MockAllowURLSecurityManager url_security_manager;
scoped_ptr<HttpAuthHandlerNegotiate::Factory> negotiate_factory(
new HttpAuthHandlerNegotiate::Factory());
- negotiate_factory->set_host_resolver(host_resolver.get());
+ negotiate_factory->set_host_resolver(host_resolver);
negotiate_factory->set_url_security_manager(&url_security_manager);
negotiate_factory->set_library(
- new GSSAPISharedLibrary("/this/library/does/not/exist"));
+ make_scoped_ptr(new GSSAPISharedLibrary("/this/library/does/not/exist")));
GURL gurl("http://www.example.com");
scoped_ptr<HttpAuthHandler> generic_handler;

Powered by Google App Engine
This is Rietveld 408576698