Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/http/http_auth_handler_negotiate.cc

Issue 1414313002: Allow dynamic updating of authentication policies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add tests Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/http/http_auth_handler_factory.cc ('K') | « net/http/http_auth_handler_factory.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler_negotiate.cc
diff --git a/net/http/http_auth_handler_negotiate.cc b/net/http/http_auth_handler_negotiate.cc
index 3262767ef1cc12fbad183af41d44c7daed802a10..cbcd8e9e8ee593941698465f34eb3bcc318f974e 100644
--- a/net/http/http_auth_handler_negotiate.cc
+++ b/net/http/http_auth_handler_negotiate.cc
@@ -61,7 +61,8 @@ int HttpAuthHandlerNegotiate::Factory::CreateAuthHandler(
url_security_manager(), resolver_,
disable_cname_lookup_, use_port_));
#elif defined(OS_ANDROID)
- if (is_unsupported_ || auth_library_->empty() || reason == CREATE_PREEMPTIVE)
+ if (is_unsupported_ || !auth_library_ || auth_library_->empty() ||
+ reason == CREATE_PREEMPTIVE)
return ERR_UNSUPPORTED_AUTH_SCHEME;
// TODO(cbentzel): Move towards model of parsing in the factory
// method and only constructing when valid.
« net/http/http_auth_handler_factory.cc ('K') | « net/http/http_auth_handler_factory.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698