Allow dynamic updating of authentication policies

chrome/browser/profiles/profile_impl_io_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl_io_data.h"
 
 #include <set>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 38 matching lines @@
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/cookie_store_factory.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/resource_context.h"
 #include "content/public/browser/storage_partition.h"
 #include "extensions/browser/extension_protocols.h"
 #include "extensions/common/constants.h"
 #include "net/base/cache_type.h"
 #include "net/base/sdch_manager.h"
 #include "net/ftp/ftp_network_layer.h"
+#include "net/http/http_auth_handler_factory.h"

[Mike Lerman, 2015/10/23 16:50:44]

You didn't edit the includes of any of the other header files, nor did you make
any other changes do this file - why is the #include for
http_auth_handler_factory now required?

(here and OTR_profile_io_data)

[aberent, 2015/10/23 17:22:27]

Because I had to change the type of IOThread::Globals::http_auth_handler_factory
to scoped_ptr<net::HttpAuthHandlerRegistryFactory> (from
scoped_ptr<net::HttpAuthHandlerFactory>). As a result it now needs to know that
HttpAuthHandlerRegistryFactory derives from HttpAuthHandlerFactory, which needs
the full definition, so needs the header file.

Without this change line 496 which calls http_auth_handler_factory.get() gives
compilation errors.

Similarly in OTR_profile_io_data.

 #include "net/http/http_cache.h"
 #include "net/http/http_network_session.h"
 #include "net/http/http_server_properties_manager.h"
 #include "net/sdch/sdch_owner.h"
 #include "net/ssl/channel_id_service.h"
 #include "net/url_request/url_request_intercepting_job_factory.h"
 #include "net/url_request/url_request_job_factory_impl.h"
 #include "storage/browser/quota/special_storage_policy.h"
 
 namespace {
@@ skipping 737 matching lines @@
     const base::Closure& completion) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   DCHECK(initialized());
 
   DCHECK(transport_security_state());
   // Completes synchronously.
   transport_security_state()->DeleteAllDynamicDataSince(time);
   DCHECK(http_server_properties_manager_);
   http_server_properties_manager_->Clear(completion);
 }