Allow dynamic updating of authentication policies

net/http/http_auth.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_AUTH_H_
 #define NET_HTTP_HTTP_AUTH_H_
 
 #include <set>
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "net/base/auth.h"
 #include "net/base/net_export.h"
 #include "net/http/http_util.h"
 
 template <class T> class scoped_refptr;
 
 namespace net {
 
 class BoundNetLog;
 class HttpAuthHandler;
 class HttpAuthHandlerFactory;
 class HttpResponseHeaders;
 
+// Auth scheme names.
+const char kBasicAuthScheme[] = "basic";

[asanka, 2015/11/04 16:05:44]

These constants have internal linkage (see http://goto/totw:105 and
http://en.cppreference.com/w/cpp/language/storage_duration). Let's move them
inside HttpAuth and make them static (i.e. "class HttpAuth { public: static
const char kBasicAuthScheme[]; ...}" along with definitions in http_auth.cc.
This is consistent with how //net has historically given symbolic names to
tokens (see http_request_headers.h for example).

[aberent, 2015/11/06 13:57:34]

Moved to separate header and source files. As discussed, putting these in
HttpAuth adds unnecessary dependencies and code to libnet_nacl.

+const char kDigestAuthScheme[] = "digest";
+const char kNtlmAuthScheme[] = "ntlm";
+const char kNegotiateAuthScheme[] = "negotiate";
+const char kSpdyProxyAuthScheme[] = "spdyproxy";
+const char kMockAuthScheme[] = "mock";
+
 // Utility class for http authentication.
 class NET_EXPORT_PRIVATE HttpAuth {
  public:
   // Http authentication can be done the the proxy server, origin server,
   // or both. This enum tracks who the target is.
   enum Target {
     AUTH_NONE = -1,
     // We depend on the valid targets (!= AUTH_NONE) being usable as indexes
     // in an array, so start from 0.
     AUTH_PROXY = 0,
@@ skipping 130 matching lines @@
       HttpAuthHandler* handler,
       const HttpResponseHeaders* headers,
       Target target,
       const std::set<Scheme>& disabled_schemes,
       std::string* challenge_used);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_AUTH_H_