Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1414293002: Revert of ipc: Add a member to IPC::Message::Header on Windows. (Closed)

Created:
5 years, 2 months ago by erikchen
Modified:
5 years, 2 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ipc: Add a member to IPC::Message::Header on Windows. (patchset #1 id:1 of https://codereview.chromium.org/1400713002/ ) Reason for revert: Likely causes crashes: https://code.google.com/p/chromium/issues/detail?id=527588#c57 Original issue's description: > ipc: Add a member to IPC::Message::Header on Windows. > > According to my most recent debugging experiments, the root cause of the crashes > that happened the first time I tried to make this change have magically > disappeared. See the bug for more details. > > BUG=527588 > > Committed: https://crrev.com/c32bea67c022c6c385463f0eec027f18b2915300 > Cr-Commit-Position: refs/heads/master@{#354889} TBR=tsepez@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=527588 Committed: https://crrev.com/e2eeedbfaefbdd4a7aa48733aff7ae15ce831fb6 Cr-Commit-Position: refs/heads/master@{#355089}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M ipc/ipc_message.h View 2 chunks +1 line, -2 lines 0 comments Download
M ipc/ipc_message.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
erikchen
Created Revert of ipc: Add a member to IPC::Message::Header on Windows.
5 years, 2 months ago (2015-10-20 17:21:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414293002/1
5 years, 2 months ago (2015-10-20 17:22:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 17:23:06 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 17:24:12 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2eeedbfaefbdd4a7aa48733aff7ae15ce831fb6
Cr-Commit-Position: refs/heads/master@{#355089}

Powered by Google App Engine
This is Rietveld 408576698