Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1414263003: Fix extension_function_histogram_value.h enum (Closed)

Created:
5 years, 2 months ago by michaelpg
Modified:
5 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix extension_function_histogram_value.h enum Remove obsolete values which should have been replaced in http://crrev.com/1239043002. BUG=546094 R=asvitkine@chromium.org NOPRESUBMIT=true Committed: https://crrev.com/ad5bd2d4ae4ea0ada750b5d1532a06296450f554 Cr-Commit-Position: refs/heads/master@{#355416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M extensions/browser/extension_function_histogram_value.h View 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
michaelpg
5 years, 2 months ago (2015-10-21 17:57:53 UTC) #2
Alexei Svitkine (slow)
lgtm
5 years, 2 months ago (2015-10-21 18:07:44 UTC) #3
Alexei Svitkine (slow)
Can you use a separate crbug for this? This way, it would be easier for ...
5 years, 2 months ago (2015-10-21 18:08:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414263003/1
5 years, 2 months ago (2015-10-21 18:19:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/111483)
5 years, 2 months ago (2015-10-21 18:31:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414263003/1
5 years, 2 months ago (2015-10-21 22:37:06 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-21 22:41:34 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 22:42:32 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad5bd2d4ae4ea0ada750b5d1532a06296450f554
Cr-Commit-Position: refs/heads/master@{#355416}

Powered by Google App Engine
This is Rietveld 408576698