Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Issue 1414233002: Unify include structure in //components/sync_driver unittests (Closed)

Created:
5 years, 2 months ago by blundell
Modified:
5 years, 2 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unify include structure in //components/sync_driver unittests This CL hoists the includes of the files being tested to the top of the unittest file in all unittests under //components/sync_driver. Committed: https://crrev.com/e772a83b47267033c022f6c10bf64eb04f057806 Cr-Commit-Position: refs/heads/master@{#355124}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M components/sync_driver/about_sync_util_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync_driver/device_info_data_type_controller_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync_driver/frontend_data_type_controller_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M components/sync_driver/glue/ui_model_worker_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/sync_driver/model_association_manager_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync_driver/non_blocking_data_type_controller_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/sync_driver/sync_policy_handler_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
blundell
I realized it wouldn't actually be a great idea to do a sweep in //chrome/browser/sync ...
5 years, 2 months ago (2015-10-20 09:39:04 UTC) #2
Nicolas Zea
LGTM, thanks!
5 years, 2 months ago (2015-10-20 18:10:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414233002/1
5 years, 2 months ago (2015-10-20 18:31:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 19:06:29 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 19:07:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e772a83b47267033c022f6c10bf64eb04f057806
Cr-Commit-Position: refs/heads/master@{#355124}

Powered by Google App Engine
This is Rietveld 408576698