Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Unified Diff: extensions/renderer/programmatic_script_injector.cc

Issue 1414223005: Remove URLs from chrome.tabs.executeScript permission warning. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed test case Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/permissions/permissions_data.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/programmatic_script_injector.cc
diff --git a/extensions/renderer/programmatic_script_injector.cc b/extensions/renderer/programmatic_script_injector.cc
index 97d68a6d8ae71fedce953d6905cac23da073dda4..8fea5aa55bfde01cc1208556d535a55d7b829490 100644
--- a/extensions/renderer/programmatic_script_injector.cc
+++ b/extensions/renderer/programmatic_script_injector.cc
@@ -133,8 +133,11 @@ void ProgrammaticScriptInjector::OnWillNotInject(
manifest_errors::kCannotAccessAboutUrl, url_.spec(),
effective_url_.GetOrigin().spec());
} else {
- error = ErrorUtils::FormatErrorMessage(
- manifest_errors::kCannotAccessPage, url_.spec());
+ // TODO(?) It would be nice to show kCannotAccessPageWithUrl here if
+ // this is triggered by an extension with tabs permission. See
+ // https://codereview.chromium.org/1414223005/diff/1/extensions/
+ // common/manifest_constants.cc#newcode269
+ error = manifest_errors::kCannotAccessPage;
}
break;
case EXTENSION_REMOVED: // no special error here.
« no previous file with comments | « extensions/common/permissions/permissions_data.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698