Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3225)

Unified Diff: extensions/common/manifest_constants.cc

Issue 1414223005: Remove URLs from chrome.tabs.executeScript permission warning. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed test case Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/manifest_constants.h ('k') | extensions/common/permissions/permissions_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/manifest_constants.cc
diff --git a/extensions/common/manifest_constants.cc b/extensions/common/manifest_constants.cc
index fe84e8ca1ab1e5f280b854ec7b69668b33109912..c4e3cd9a45919dfe973edb34d37096bcde59cf7c 100644
--- a/extensions/common/manifest_constants.cc
+++ b/extensions/common/manifest_constants.cc
@@ -262,7 +262,15 @@ const char kCannotAccessAboutUrl[] =
const char kCannotAccessChromeUrl[] = "Cannot access a chrome:// URL";
const char kCannotAccessExtensionUrl[] =
"Cannot access a chrome-extension:// URL of different extension";
+// This deliberately does not contain a URL. Otherwise an extension can parse
+// error messages and determine the URLs of open tabs without having appropriate
+// permissions to see these URLs.
const char kCannotAccessPage[] =
+ "Cannot access contents of the page. "
+ "Extension manifest must request permission to access the respective host.";
+// Use this error message with caution and only if the extension triggering it
+// has tabs permission. Otherwise, URLs may be leaked to extensions.
+const char kCannotAccessPageWithUrl[] =
"Cannot access contents of url \"*\". "
"Extension manifest must request permission to access this host.";
const char kCannotChangeExtensionID[] =
« no previous file with comments | « extensions/common/manifest_constants.h ('k') | extensions/common/permissions/permissions_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698