Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3048)

Unified Diff: chrome/test/data/extensions/api_test/executescript/basic/test.js

Issue 1414223005: Remove URLs from chrome.tabs.executeScript permission warning. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed test case Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/executescript/basic/test.js
diff --git a/chrome/test/data/extensions/api_test/executescript/basic/test.js b/chrome/test/data/extensions/api_test/executescript/basic/test.js
index 39102cefc260f6374cf9fc7975a2446375fa5039..5937596807b92521cc1b4c83c3b6b2e82f53c4de 100644
--- a/chrome/test/data/extensions/api_test/executescript/basic/test.js
+++ b/chrome/test/data/extensions/api_test/executescript/basic/test.js
@@ -91,6 +91,8 @@ chrome.test.getConfig(function(config) {
chrome.tabs.update(tabId, { url: testFailureUrl }, function() {
var script_file = {};
script_file.code = "document.title = 'executeScript';";
+ // The error message should contain the URL of the site for which it
+ // failed because the extension has the tabs permission.
chrome.tabs.executeScript(tabId, script_file, fail(
'Cannot access contents of url "' + testFailureUrl +
'". Extension manifest must request permission to access this ' +

Powered by Google App Engine
This is Rietveld 408576698