Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2033)

Unified Diff: extensions/common/permissions/permissions_data.cc

Issue 1414223005: Remove URLs from chrome.tabs.executeScript permission warning. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/permissions_data.cc
diff --git a/extensions/common/permissions/permissions_data.cc b/extensions/common/permissions/permissions_data.cc
index ea66b6ccd66ddc8bd55093c40a699dda27e805db..fbcee3ad4b803f0012526bba55759550f1e94745 100644
--- a/extensions/common/permissions/permissions_data.cc
+++ b/extensions/common/permissions/permissions_data.cc
@@ -348,10 +348,9 @@ PermissionsData::AccessType PermissionsData::CanRunOnPage(
if (withheld_url_patterns.MatchesURL(document_url))
return ACCESS_WITHHELD;
- if (error) {
- *error = ErrorUtils::FormatErrorMessage(manifest_errors::kCannotAccessPage,
- document_url.spec());
- }
+ if (error)
+ *error = manifest_errors::kCannotAccessPage;
+
return ACCESS_DENIED;
}

Powered by Google App Engine
This is Rietveld 408576698