chrome/test/data/extensions/api_test/content_scripts/permissions/background.js - Issue 1414223005: Remove URLs from chrome.tabs.executeScript permission warning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/content_scripts/permissions/background.js

Issue 1414223005: Remove URLs from chrome.tabs.executeScript permission warning. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/api_test/active_tab/background.js ('K') | « chrome/test/data/extensions/api_test/active_tab/background.js ('k') | chrome/test/data/extensions/api_test/executescript/basic/test.js » ('j') | extensions/common/manifest_constants.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/content_scripts/permissions/background.js

diff --git a/chrome/test/data/extensions/api_test/content_scripts/permissions/background.js b/chrome/test/data/extensions/api_test/content_scripts/permissions/background.js

index fdd1278519c66cc41cd81b1089e462a0a22f3690..7bb730966fd48693656debcfdd11304d2004bf10 100644

--- a/chrome/test/data/extensions/api_test/content_scripts/permissions/background.js

+++ b/chrome/test/data/extensions/api_test/content_scripts/permissions/background.js

@@ -16,11 +16,6 @@ function testUrl(domain) {

'/extensions/test_file.html';

}

-function error(domain) {

- return 'Cannot access contents of url "' + testUrl(domain) + '".' +

- ' Extension manifest must request permission to access this host.';

// Creates a new tab, navigated to the specified |domain|.

function createTestTab(domain, callback) {

var createdTabId = -1;

@@ -49,7 +44,9 @@ chrome.test.getConfig(function(config) {

testTabId = tab.id;

chrome.tabs.executeScript(

tab.id, {code: 'document.title = "success"'},

- callbackFail(error('a.com')));

+ callbackFail('Cannot access contents of a page. ' +

+ 'Extension manifest must request permission to access ' +

+ 'the respective host.'));

}));