Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1414223004: [turbofan] Move platform-independent bits of VisitTailCall to instruction-selector.cc (Closed)

Created:
5 years, 1 month ago by Jarin
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Move platform-independent bits of VisitTailCall to instruction-selector.cc Committed: https://crrev.com/f5d42d04d750b8e71e2720595717300a45c7883a Cr-Commit-Position: refs/heads/master@{#31561}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -664 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +1 line, -79 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +1 line, -104 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +1 line, -78 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +73 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +1 line, -80 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +1 line, -80 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +1 line, -88 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +1 line, -77 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +1 line, -78 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jarin
Could you take a look, please?
5 years, 1 month ago (2015-10-26 12:46:55 UTC) #2
Benedikt Meurer
LGTM, nice.
5 years, 1 month ago (2015-10-26 12:53:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414223004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414223004/1
5 years, 1 month ago (2015-10-26 12:54:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 13:01:00 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 13:01:34 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f5d42d04d750b8e71e2720595717300a45c7883a
Cr-Commit-Position: refs/heads/master@{#31561}

Powered by Google App Engine
This is Rietveld 408576698