Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 1414203009: Changed the constructor of BufferedRawMachineAssemblerTester. (Closed)

Created:
5 years, 1 month ago by ahaas
Modified:
5 years, 1 month ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Changed the constructor of BufferedRawMachineAssemblerTester. This change does not change how the BufferedRawMachineAssemblerTester is used in tests, but it makes its construction in other constructors (e.g. in the WasmRunner) cleaner. R=titzer@chromium.org Committed: https://crrev.com/2c74ec3fecb81dbfa69f9e86dd731299ca6d96dd Cr-Commit-Position: refs/heads/master@{#31850}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Renamed DetermineReturnIndex to ComputeParameterCount #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -22 lines) Patch
M test/cctest/compiler/codegen-tester.h View 1 2 chunks +24 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ahaas
5 years, 1 month ago (2015-11-04 12:31:28 UTC) #1
titzer
https://codereview.chromium.org/1414203009/diff/1/test/cctest/compiler/codegen-tester.h File test/cctest/compiler/codegen-tester.h (right): https://codereview.chromium.org/1414203009/diff/1/test/cctest/compiler/codegen-tester.h#newcode180 test/cctest/compiler/codegen-tester.h:180: static uint32_t DetermineReturnIndex(MachineType p0, MachineType p1, I think this ...
5 years, 1 month ago (2015-11-05 17:39:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414203009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414203009/20001
5 years, 1 month ago (2015-11-06 07:21:02 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-06 07:22:32 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 07:23:05 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c74ec3fecb81dbfa69f9e86dd731299ca6d96dd
Cr-Commit-Position: refs/heads/master@{#31850}

Powered by Google App Engine
This is Rietveld 408576698