[Interpreter] Removes unnecessary jumps and dead code from If and loops.

src/interpreter/bytecode-generator.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/bytecode-generator.h"
 
 #include "src/compiler.h"
 #include "src/interpreter/control-flow-builders.h"
 #include "src/objects.h"
 #include "src/parser.h"
@@ skipping 471 matching lines @@
   EffectResultScope effect_scope(this);
   VisitForEffect(stmt->expression());
 }
 
 
 void BytecodeGenerator::VisitEmptyStatement(EmptyStatement* stmt) {
 }
 
 
 void BytecodeGenerator::VisitIfStatement(IfStatement* stmt) {
-  // TODO(oth): Spot easy cases where there code would not need to
-  // emit the then block or the else block, e.g. condition is
-  // obviously true/1/false/0.
-
   BytecodeLabel else_label, end_label;
-
-  VisitForAccumulatorValue(stmt->condition());
-  builder()->CastAccumulatorToBoolean();
-  builder()->JumpIfFalse(&else_label);
-  Visit(stmt->then_statement());
-  if (stmt->HasElseStatement()) {
-    builder()->Jump(&end_label);
-    builder()->Bind(&else_label);
-    Visit(stmt->else_statement());
+  if (stmt->condition()->ToBooleanIsTrue()) {
+    // Generate only then block.
+    Visit(stmt->then_statement());
+  } else if (stmt->condition()->ToBooleanIsFalse()) {
+    // Generate only else block if it exists.
+    if (stmt->HasElseStatement()) {
+      Visit(stmt->else_statement());
+    }
   } else {
-    builder()->Bind(&else_label);
+    VisitForAccumulatorValue(stmt->condition());
+    builder()->CastAccumulatorToBoolean();
+    builder()->JumpIfFalse(&else_label);
+    Visit(stmt->then_statement());
+    if (stmt->HasElseStatement()) {
+      builder()->Jump(&end_label);
+      builder()->Bind(&else_label);
+      Visit(stmt->else_statement());
+    } else {
+      builder()->Bind(&else_label);
+    }
+    builder()->Bind(&end_label);
   }
-  builder()->Bind(&end_label);
 }
 
 
 void BytecodeGenerator::VisitSloppyBlockFunctionStatement(
     SloppyBlockFunctionStatement* stmt) {
   Visit(stmt->statement());
 }
 
 
 void BytecodeGenerator::VisitContinueStatement(ContinueStatement* stmt) {
@@ skipping 22 matching lines @@
   UNIMPLEMENTED();
 }
 
 
 void BytecodeGenerator::VisitCaseClause(CaseClause* clause) { UNIMPLEMENTED(); }
 
 
 void BytecodeGenerator::VisitDoWhileStatement(DoWhileStatement* stmt) {
   LoopBuilder loop_builder(builder());
   ControlScopeForIteration execution_control(this, stmt, &loop_builder);
+  BytecodeLabel body_label, condition_label, done_label;
 
-  BytecodeLabel body_label, condition_label, done_label;
-  builder()->Bind(&body_label);
-  Visit(stmt->body());
-  builder()->Bind(&condition_label);
-  VisitForAccumulatorValue(stmt->cond());
-  builder()->JumpIfTrue(&body_label);
-  builder()->Bind(&done_label);
-
+  if (stmt->cond()->ToBooleanIsFalse()) {
+    Visit(stmt->body());
+    // Bind condition_label and done_label for processing continue and break.
+    builder()->Bind(&condition_label);
+    builder()->Bind(&done_label);
+  } else {
+    builder()->Bind(&body_label);
+    Visit(stmt->body());

[rmcilroy, 2015/10/30 15:49:53]

nit - add line of whitespace here between body and condition check

[mythria, 2015/11/02 10:46:07]

Done.

+    builder()->Bind(&condition_label);
+    if (stmt->cond()->ToBooleanIsTrue()) {
+      builder()->Jump(&body_label);
+    } else {
+      VisitForAccumulatorValue(stmt->cond());
+      builder()->JumpIfTrue(&body_label);
+    }
+    builder()->Bind(&done_label);
+  }
   loop_builder.SetBreakTarget(done_label);
   loop_builder.SetContinueTarget(condition_label);
 }
 
 
 void BytecodeGenerator::VisitWhileStatement(WhileStatement* stmt) {
   LoopBuilder loop_builder(builder());
   ControlScopeForIteration execution_control(this, stmt, &loop_builder);
 
   BytecodeLabel body_label, condition_label, done_label;
-  builder()->Jump(&condition_label);
+  if (stmt->cond()->ToBooleanIsFalse()) {
+    // If the condition is false there is no need to generating the loop.
+    return;
+  }
+
+  if (!stmt->cond()->ToBooleanIsTrue()) {
+    builder()->Jump(&condition_label);
+  }
   builder()->Bind(&body_label);
   Visit(stmt->body());

[rmcilroy, 2015/10/30 15:49:53]

nit - add a line of whitespace here  between body and condition check

[mythria, 2015/11/02 10:46:07]

Done.

   builder()->Bind(&condition_label);
-  VisitForAccumulatorValue(stmt->cond());
-  builder()->JumpIfTrue(&body_label);
+  if (stmt->cond()->ToBooleanIsTrue()) {
+    builder()->Jump(&body_label);
+  } else {
+    VisitForAccumulatorValue(stmt->cond());
+    builder()->JumpIfTrue(&body_label);
+  }
   builder()->Bind(&done_label);
 
   loop_builder.SetBreakTarget(done_label);
   loop_builder.SetContinueTarget(condition_label);
 }
 
 
 void BytecodeGenerator::VisitForStatement(ForStatement* stmt) {
   LoopBuilder loop_builder(builder());
   ControlScopeForIteration execution_control(this, stmt, &loop_builder);
 
   if (stmt->init() != nullptr) {
     Visit(stmt->init());
   }
 
+  if (stmt->cond() && stmt->cond()->ToBooleanIsFalse()) {
+    // If the condition is known to be false there is no need to generate
+    // body, next or condition blocks. Init block should be generated.
+    return;
+  }
+
   BytecodeLabel body_label, condition_label, next_label, done_label;
-  if (stmt->cond() != nullptr) {
+  if (stmt->cond() && !stmt->cond()->ToBooleanIsTrue()) {
     builder()->Jump(&condition_label);
   }
   builder()->Bind(&body_label);
   Visit(stmt->body());
   builder()->Bind(&next_label);
   if (stmt->next() != nullptr) {
     Visit(stmt->next());
   }
-  if (stmt->cond()) {
+  if ((stmt->cond() == nullptr) || stmt->cond()->ToBooleanIsTrue()) {

[rmcilroy, 2015/10/30 15:49:53]

nit - you removed the '== nullptr' above and added it here. Just one or the
other (I'd just remove the '== nullptr')

[mythria, 2015/11/02 10:46:07]

Done.

+    builder()->Jump(&body_label);
+  } else {
     builder()->Bind(&condition_label);
     VisitForAccumulatorValue(stmt->cond());
     builder()->JumpIfTrue(&body_label);
-  } else {
-    builder()->Jump(&body_label);
   }
   builder()->Bind(&done_label);
 
   loop_builder.SetBreakTarget(done_label);
   loop_builder.SetContinueTarget(next_label);
 }
 
 
 void BytecodeGenerator::VisitForInStatement(ForInStatement* stmt) {
   UNIMPLEMENTED();
@@ skipping 1329 matching lines @@
 }
 
 
 int BytecodeGenerator::feedback_index(FeedbackVectorSlot slot) const {
   return info()->feedback_vector()->GetIndex(slot);
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8