Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1414193002: Plug RemoteFrame leak in WebFrameTest.SwapMainFrameWhileLoading. (Closed)

Created:
5 years, 2 months ago by sof
Modified:
5 years, 2 months ago
Reviewers:
haraken, dcheng
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plug RemoteFrame leak in WebFrameTest.SwapMainFrameWhileLoading. R=haraken BUG=526423 Committed: https://crrev.com/35a3532b0f4eff7abb0fdae66cdbb2d810405b19 Cr-Commit-Position: refs/heads/master@{#355029}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +16 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
5 years, 2 months ago (2015-10-20 07:36:52 UTC) #2
haraken
LGTM
5 years, 2 months ago (2015-10-20 07:42:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414193002/1
5 years, 2 months ago (2015-10-20 07:45:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 10:33:59 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 10:35:32 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/35a3532b0f4eff7abb0fdae66cdbb2d810405b19
Cr-Commit-Position: refs/heads/master@{#355029}

Powered by Google App Engine
This is Rietveld 408576698