Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Issue 141413007: NaCl: Expose NaClApp to the embedding layer. (Closed)

Created:
6 years, 10 months ago by teravest
Modified:
6 years, 10 months ago
Reviewers:
Mark Seaborn
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@embedding_api
Visibility:
Public.

Description

NaCl: Expose NaClApp to the embedding layer. This change exposes NaClApp and separate methods for loading and starting a module to the embedding API. It was initially proposed that a single method in the embedding API would take care of loading and starting a module. I found this difficult to implement in practice because the following 3 operations must occur in order: - Load NaCl module. - Initialize reverse service. - Start NaCl module. After the reverse service is moved to Chromium IPC from SRPC, this may be easier to manage, but for now, I'd like to have two separate methods for loading and starting a NaCl module. I've tested this change against the current HEAD of chrome, and with a prototype chrome change that calls the two methods introduced in this API. Chrome change: https://codereview.chromium.org/131413009/ BUG=http://crbug.com/333950

Patch Set 1 #

Patch Set 2 : Use git cl upload properly #

Patch Set 3 : Reupload. #

Patch Set 4 : Tighten up StartModule logic #

Patch Set 5 : Fix compile error #

Patch Set 6 : C90 compile fix #

Patch Set 7 : Expose LoadModule status for UMA tracking. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -59 lines) Patch
M src/trusted/service_runtime/sel_main_chrome.h View 1 2 3 4 5 6 2 chunks +9 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/sel_main_chrome.c View 1 2 3 4 5 6 9 chunks +93 lines, -59 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
teravest
6 years, 10 months ago (2014-02-03 15:05:10 UTC) #1
teravest
6 years, 10 months ago (2014-02-06 16:33:38 UTC) #2
ping?

It looks like you're making some changes in a similar area, and I'd like to get
this embedding API nailed down. It looks like I'll have to move this to public/
anyway, but I really want to get your feedback on how NaClApp creation should
look, and how LoadModule()/StartModule() should be exposed.

Powered by Google App Engine
This is Rietveld 408576698