Index: content/child/blob_storage/blob_consolidation.cc |
diff --git a/content/child/blob_storage/blob_consolidation.cc b/content/child/blob_storage/blob_consolidation.cc |
index c912699d37579d6aefb78fed0320d7f4c54397b2..dc863a1996fc6760742a6703186521bece30a803 100644 |
--- a/content/child/blob_storage/blob_consolidation.cc |
+++ b/content/child/blob_storage/blob_consolidation.cc |
@@ -10,10 +10,22 @@ |
#include <limits> |
#include <string> |
+#include "base/bind.h" |
+#include "base/callback.h" |
+ |
using storage::DataElement; |
using blink::WebThreadSafeData; |
namespace content { |
+namespace { |
+bool WriteMemory(void* memory_out, |
+ size_t total_read, |
+ const char* memory, |
+ size_t size) { |
+ memcpy(static_cast<char*>(memory_out) + total_read, memory, size); |
+ return true; |
+} |
+} // namespace |
using ReadStatus = BlobConsolidation::ReadStatus; |
@@ -99,11 +111,13 @@ void BlobConsolidation::AddFileSystemItem(const GURL& url, |
item.expected_modification_time = expected_modification_time; |
} |
-ReadStatus BlobConsolidation::ReadMemory(size_t consolidated_item_index, |
- size_t consolidated_offset, |
- size_t consolidated_size, |
- void* memory_out) { |
- CHECK(memory_out); |
+ReadStatus BlobConsolidation::VisitMemory( |
+ size_t consolidated_item_index, |
+ size_t consolidated_offset, |
+ size_t consolidated_size, |
+ base::Callback<bool(size_t /* total_memory_read */, |
+ const char* /* memory */, |
+ size_t /* memory_size */)> visitor) const { |
if (consolidated_item_index >= consolidated_items_.size()) |
return ReadStatus::ERROR_OUT_OF_BOUNDS; |
@@ -155,12 +169,23 @@ ReadStatus BlobConsolidation::ReadMemory(size_t consolidated_item_index, |
mid < num_items && memory_read < consolidated_size; mid++) { |
size_t read_size = std::min(item.data[mid].size() - offset_from_mid, |
consolidated_size - memory_read); |
- memcpy(static_cast<char*>(memory_out) + memory_read, |
- item.data[mid].data() + offset_from_mid, read_size); |
+ bool cont = visitor.Run(memory_read, |
+ item.data[mid].data() + offset_from_mid, read_size); |
+ if (!cont) |
kinuko
2016/04/15 15:02:31
What's 'cont'? Continue? It's not too obvious wh
dmurph
2016/04/20 21:15:34
Added comment, and comment on method signature.
|
+ return ReadStatus::EARLY_ABORT; |
offset_from_mid = 0; |
memory_read += read_size; |
} |
return ReadStatus::OK; |
} |
+ReadStatus BlobConsolidation::ReadMemory(size_t consolidated_item_index, |
+ size_t consolidated_offset, |
+ size_t consolidated_size, |
+ void* memory_out) const { |
+ CHECK(memory_out); |
+ return VisitMemory(consolidated_item_index, consolidated_offset, |
+ consolidated_size, base::Bind(&WriteMemory, memory_out)); |
+} |
+ |
} // namespace content |