chrome/browser/extensions/api/identity/identity_apitest.cc - Issue 14141006: [components] Switch {RefCounted}ProfileKeyedService to use BrowserContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/identity_apitest.cc

Issue 14141006: [components] Switch {RefCounted}ProfileKeyedService to use BrowserContext (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: for review Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/linux/system.gyp ('K') | « chrome/browser/extensions/api/discovery/suggested_links_registry_factory.cc ('k') | chrome/browser/extensions/api/idle/idle_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/identity/identity_apitest.cc

diff --git a/chrome/browser/extensions/api/identity/identity_apitest.cc b/chrome/browser/extensions/api/identity/identity_apitest.cc

index 9bf130d64a4e7858b8a6ea2d68f6b25545fc91c3..e2c0ebbd25ab16d183ed5c1eae5981f6e9d5c799 100644

--- a/chrome/browser/extensions/api/identity/identity_apitest.cc

+++ b/chrome/browser/extensions/api/identity/identity_apitest.cc

@@ -180,8 +180,8 @@ class TestOAuth2MintTokenFlow : public OAuth2MintTokenFlow {

OAuth2MintTokenFlow::Delegate* delegate_;

};

-ProfileKeyedService* IdentityAPITestFactory(Profile* profile) {

- return new IdentityAPI(profile);

+ProfileKeyedService* IdentityAPITestFactory(content::BrowserContext* profile) {

Jói 2013/04/23 22:45:22 nit: Might be nice to rename |profile| to |context

Paweł Hajdan Jr. 2013/04/23 22:58:11 I think I'll be changing that later, also includin

Jói 2013/04/24 09:09:10 OK, fine by me.

+ return new IdentityAPI(static_cast<Profile*>(profile));

}

} // namespace