[components] Switch {RefCounted}ProfileKeyedService to use BrowserContext

build/linux/system.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'conditions': [
       ['sysroot!=""', {
         'pkg-config': './pkg-config-wrapper "<(sysroot)" "<(target_arch)"',
       }, {
@@ skipping 25 matching lines @@
           'target_name': 'gtk',
           'type': 'none',
           'toolsets': ['host', 'target'],
           'variables': {
             # gtk requires gmodule, but it does not list it as a dependency
             # in some misconfigured systems.
             'gtk_packages': 'gmodule-2.0 gtk+-2.0 gthread-2.0',
           },
           'conditions': [
             ['_toolset=="target"', {
-              'direct_dependent_settings': {
+              'all_dependent_settings': {

[Jói, 2013/04/23 22:45:22]

Were the changes in this file meant to be part of this changelist?

[Paweł Hajdan Jr., 2013/04/23 22:58:11]

Unfortunately, yes. Otherwise it doesn't compile.

[Jói, 2013/04/24 09:09:10]

Hmm, do you know why?

[Paweł Hajdan Jr., 2013/04/25 17:51:43]

The error message is:

  CXX(target) out/Debug/obj.target/apps/apps/app_restore_service_factory.o
In file included from ./content/public/browser/browser_context.h:13:0,
                 from ./chrome/browser/profiles/profile.h:16,
                 from apps/app_restore_service_factory.cc:8:
./ui/base/clipboard/clipboard.h:23:21: fatal error: gdk/gdk.h: No such file or
directory

And it's caused by GTK+ include path not being propagated to the build target
that contains apps/app_restore_service_factory.cc . The problem is: why should
apps gyp target explicitly include a gtk+ dependency, while it exists there only
due to transitive header inclusion?

                 'cflags': [
                   '<!@(<(pkg-config) --cflags <(gtk_packages))',
                 ],
               },
               'link_settings': {
                 'ldflags': [
                   '<!@(<(pkg-config) --libs-only-L --libs-only-other <(gtk_packages))',
                 ],
                 'libraries': [
                   '<!@(<(pkg-config) --libs-only-l <(gtk_packages))',
                 ],
               },
             }, {
-              'direct_dependent_settings': {
+              'all_dependent_settings': {
                 'cflags': [
                   '<!@(pkg-config --cflags <(gtk_packages))',
                 ],
               },
               'link_settings': {
                 'ldflags': [
                   '<!@(pkg-config --libs-only-L --libs-only-other <(gtk_packages))',
                 ],
                 'libraries': [
                   '<!@(pkg-config --libs-only-l <(gtk_packages))',
@@ skipping 763 matching lines @@
             ],
             'libraries': [
               '<!@(<(pkg-config) --libs-only-l libudev)',
             ],
           },
         }],
       ],
     },
   ],
 }