Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 14141005: Don't take the address of a temporary (Closed)

Created:
7 years, 8 months ago by Reid Kleckner
Modified:
7 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Don't take the address of a temporary MSVC extends the lifetime of such objects, but clang does not, and it errors on this construct. R=ananta@chromium.org BUG=82385 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194997

Patch Set 1 #

Patch Set 2 : reset base url #

Patch Set 3 : attempting to fix base url #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webkit/plugins/npapi/webplugin_delegate_impl_win.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Reid Kleckner
7 years, 8 months ago (2013-04-18 18:12:17 UTC) #1
ananta
This file should only be compiled on windows. Am I missing something?
7 years, 8 months ago (2013-04-18 18:17:45 UTC) #2
Reid Kleckner (google)
For various reasons, we're investigating clang compilation on Windows. See the linked bug. On Thu, ...
7 years, 8 months ago (2013-04-18 18:30:07 UTC) #3
ananta
lgtm
7 years, 8 months ago (2013-04-18 19:40:28 UTC) #4
Reid Kleckner
Thanks! Committing.
7 years, 8 months ago (2013-04-18 19:43:08 UTC) #5
Reid Kleckner
reset base url
7 years, 8 months ago (2013-04-18 20:02:04 UTC) #6
Reid Kleckner
7 years, 8 months ago (2013-04-18 20:39:43 UTC) #7
attempting to fix base url

Powered by Google App Engine
This is Rietveld 408576698