Issue 1414083004: Output precompiled snapshot size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1414083004: Output precompiled snapshot size. (Closed)

Created:
5 years, 1 month ago by rmacnak

Modified:
5 years, 1 month ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Output precompiled snapshot size. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/862307ccacac1bdb5d6c6fd16303172d36667e6f

Patch Set 2 : \ #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	runtime/vm/snapshot.h	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
	M	runtime/vm/snapshot.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Florian Schneider

lgtm https://codereview.chromium.org/1414083004/diff/1/runtime/vm/snapshot.h File runtime/vm/snapshot.h (right): https://codereview.chromium.org/1414083004/diff/1/runtime/vm/snapshot.h#newcode854 runtime/vm/snapshot.h:854: binary_size_ += sizeof(uword); s/sizeof(uword)/sizeof(value)/

5 years, 1 month ago (2015-11-04 22:56:47 UTC) #3

rmacnak

Committed patchset #2 (id:20001) manually as 862307ccacac1bdb5d6c6fd16303172d36667e6f (presubmit successful).

5 years, 1 month ago (2015-11-04 23:13:20 UTC) #4

rmacnak

5 years, 1 month ago (2015-11-04 23:14:11 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/1414083004/diff/1/runtime/vm/snapshot.h
File runtime/vm/snapshot.h (right):

https://codereview.chromium.org/1414083004/diff/1/runtime/vm/snapshot.h#newco...
runtime/vm/snapshot.h:854: binary_size_ += sizeof(uword);
On 2015/11/04 22:56:47, Florian Schneider wrote:
> s/sizeof(uword)/sizeof(value)/

Done.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1414083004: Output precompiled snapshot size. (Closed)

Description

Patch Set 1 #

Patch Set 2 : \ #

Messages