Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: components/cronet/url_request_context_config.h

Issue 1414053008: [Cronet] Replace setExperimentalQuicConnectionOptions with a more general API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove format from Javadoc Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/url_request_context_config.h
diff --git a/components/cronet/url_request_context_config.h b/components/cronet/url_request_context_config.h
index c40a112c5b108d7638349ecb7d3080d2054981e2..d5d8a9876b5a52bfd71b781b3b47408db18649f2 100644
--- a/components/cronet/url_request_context_config.h
+++ b/components/cronet/url_request_context_config.h
@@ -75,8 +75,17 @@ struct URLRequestContextConfig {
std::string user_agent;
// App-provided list of servers that support QUIC.
ScopedVector<QuicHint> quic_hints;
- // Comma-separted list of QUIC connection options.
- std::string quic_connection_options;
+
pauljensen 2015/11/04 15:03:26 remove blank line to match style here?
xunjieli 2015/11/06 14:48:51 Done.
+ // Experimental options encoded as a string in a JSON format containing
+ // experiments and their corresponding configuration options. The format
+ // is a JSON object with the name of the experiment as the key, and the
+ // configuration options as the value. The configuration options are
+ // encoded as a JSON object with option name as the key and option value
+ // as the value. An example:
pauljensen 2015/11/04 15:03:26 Can we remove the "The configuration options are..
xunjieli 2015/11/06 14:48:51 Done.
+ // {"experiment1": {"option1": "option_value1", "option2": "option_value2",
+ // ...}, "experiment2: {"option3", "option_value3", ...}, ...}
+ std::string experimental_options;
+
pauljensen 2015/11/04 15:03:26 remove blank line to match style here?
xunjieli 2015/11/06 14:48:51 Done.
// Enable Data Reduction Proxy with authentication key.
std::string data_reduction_proxy_key;
std::string data_reduction_primary_proxy;

Powered by Google App Engine
This is Rietveld 408576698