Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: src/IceInstARM32.cpp

Issue 1414043015: Fix frame pointer loads/stores in the ARM integrated assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Add comment to test case. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceInstARM32.cpp
diff --git a/src/IceInstARM32.cpp b/src/IceInstARM32.cpp
index dd7d52693b3fc95c1990a4275bf09cbd7748ff9e..b7eae71189fca27f73c69235788c1352dcbeb38c 100644
--- a/src/IceInstARM32.cpp
+++ b/src/IceInstARM32.cpp
@@ -765,7 +765,7 @@ void InstARM32Mov::emitIASSingleDestSingleSource(const Cfg *Func) const {
if (isMemoryAccess(Src0)) {
// TODO(kschimpf) Figure out how to do ldr on CoreVPFMove? (see
// emitSingleDestSingleSource, local variable LoadOpcode).
- return Asm->ldr(Dest, Src0, getPredicate());
+ return Asm->ldr(Dest, Src0, getPredicate(), Func->getTarget());
}
return Asm->mov(Dest, Src0, getPredicate());
} else {
@@ -775,7 +775,7 @@ void InstARM32Mov::emitIASSingleDestSingleSource(const Cfg *Func) const {
const bool CoreVFPMove = isMoveBetweenCoreAndVFPRegisters(Dest, Src0);
if (Src0IsVector || Src0IsScalarFP || CoreVFPMove)
return Asm->setNeedsTextFixup();
- return Asm->str(Src0, Dest, getPredicate());
+ return Asm->str(Src0, Dest, getPredicate(), Func->getTarget());
}
Asm->setNeedsTextFixup();
}
@@ -995,7 +995,7 @@ template <> void InstARM32Ldr::emitIAS(const Cfg *Func) const {
// TODO(kschimpf) Handle case.
Asm->setNeedsTextFixup();
else
- Asm->ldr(Dest, getSrc(0), getPredicate());
+ Asm->ldr(Dest, getSrc(0), getPredicate(), Func->getTarget());
if (Asm->needsTextFixup())
emitUsingTextFixup(Func);
}
@@ -1364,7 +1364,7 @@ void InstARM32Str::emitIAS(const Cfg *Func) const {
// TODO(kschimpf) Handle case.
Asm->setNeedsTextFixup();
else
- Asm->str(getSrc(0), getSrc(1), getPredicate());
+ Asm->str(getSrc(0), getSrc(1), getPredicate(), Func->getTarget());
if (Asm->needsTextFixup())
emitUsingTextFixup(Func);
}

Powered by Google App Engine
This is Rietveld 408576698