Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1414043011: Mark returns from inside the try of a try/catch as ones that exit the try. (Closed)

Created:
5 years, 1 month ago by Kevin Millikin (Google)
Modified:
5 years, 1 month ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark returns from inside the try of a try/catch as ones that exit the try. At construction time, jumps from within the try block of a try/catch are marked as ones that exit the try block. This is relied on for correctness. Specifically, it prevents moving code from outside the try into the scope of the try. Return jumps were from within the try were not marked because it was unnecessary. In the presence of inlining, returns are turned into jumps to a local join-point continuation. These jumps must be marked for correctness. R=asgerf@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/45004655a1bb763d12ddb092137a4de99a4f776f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -17 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 11 chunks +46 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Google)
5 years, 1 month ago (2015-11-05 13:28:01 UTC) #1
asgerf
LGTM
5 years, 1 month ago (2015-11-05 13:30:37 UTC) #2
Kevin Millikin (Google)
5 years, 1 month ago (2015-11-06 08:31:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
45004655a1bb763d12ddb092137a4de99a4f776f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698