Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1414033013: Add string mapping for INVALIDATOR_SHUTTING_DOWN. (Closed)

Created:
5 years, 1 month ago by wkorman
Modified:
5 years, 1 month ago
Reviewers:
dcheng, pavely
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add string mapping for INVALIDATOR_SHUTTING_DOWN. It looks like this was just an oversight as part of http://crrev.com/1380103004. Without this debug Windows builds occasionally pop up alert dialog on shutdown. BUG=546640 Committed: https://crrev.com/356bb8904a7a195ed7c500b35f37df7ad0b443c8 Cr-Commit-Position: refs/heads/master@{#358419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/invalidation/public/invalidator_state.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
wkorman
Small debug assert failing, noticed while working on unrelated ScopedTempDir issue.
5 years, 1 month ago (2015-11-06 19:12:25 UTC) #2
dcheng
lgtm
5 years, 1 month ago (2015-11-06 20:52:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414033013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414033013/1
5 years, 1 month ago (2015-11-06 21:03:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 22:01:02 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 22:02:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/356bb8904a7a195ed7c500b35f37df7ad0b443c8
Cr-Commit-Position: refs/heads/master@{#358419}

Powered by Google App Engine
This is Rietveld 408576698