Issue 1414033010: Merge to XFA: Remove state from RebuildCrossRef state-machine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1414033010: Merge to XFA: Remove state from RebuildCrossRef state-machine. (Closed)

Created:
5 years, 1 month ago by dsinclair

Modified:
5 years, 1 month ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Remove state from RebuildCrossRef state-machine. The state '12' is only used once. This CL folds the contents of state 12 back into the place where we set our state to 12. This works because all state 12 does is decrement the loop counter so we process the same character again and move us to state 0. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1430643007 . (cherry picked from commit 395fbedc65e1261f1fb9189205501f4856235290) Committed: https://pdfium.googlesource.com/pdfium/+/42e0ccfcdd5de93f75448a030efa42182b417cb5

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -8 lines)			Patch
	M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View		1 chunk	+1 line, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

dsinclair

Committed patchset #1 (id:1) manually as 42e0ccfcdd5de93f75448a030efa42182b417cb5 (presubmit successful).

5 years, 1 month ago (2015-11-04 19:05:28 UTC) #2

Message was sent while issue was closed.

lgtm