chrome/browser/ui/cocoa/browser_window_controller_private.mm - Issue 1414033009: Implement a Menu Item to Hide the Toolbar in Fullscreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 1414033009: Implement a Menu Item to Hide the Toolbar in Fullscreen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and merge code Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/exclusive_access/exclusive_access_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm

index 7d04649ebce586d6bf04a6afd59b6b2f4fa32096..8264076a93ac27fc2fd36486f6ab885dbf71feb7 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm

@@ -225,6 +225,8 @@ willPositionSheet:(NSWindow*)sheet

}

- (void)layoutSubviews {

+ // TODO(spqchan): Change blockLayoutSubviews so that it only blocks the web

+ // content from resizing.

if (blockLayoutSubviews_)

return;

@@ -764,6 +766,7 @@ willPositionSheet:(NSWindow*)sheet

isUsingCustomAnimation_ = NO;

[self showFullscreenExitBubbleIfNecessary];

+ [self layoutSubviews];

browser_->WindowFullscreenStateChanged();

}

@@ -826,7 +829,7 @@ willPositionSheet:(NSWindow*)sheet

->fullscreen_controller()

->IsWindowFullscreenForTabOrPending()) {

style = fullscreen_mac::OMNIBOX_TABS_NONE;

- } else if (enteringPresentationMode_) {

+ } else if (enteringPresentationMode_ || [self shouldHideFullscreenToolbar]) {

style = fullscreen_mac::OMNIBOX_TABS_HIDDEN;

} else {

style = fullscreen_mac::OMNIBOX_TABS_PRESENT;