Do not generate warnings when noSuchMethod is inherited (issue 24337)

Do not generate warnings when noSuchMethod is inherited (issue 24337)

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/cc8f64b824ac0bd7607ffd330f0b4c287ee25e0f

[Brian Wilkerson, 2015-10-19 21:15:43]

Description was changed from

==========
Do not generate warnings when noSuchMethod is inherited
==========

to

==========
Do not generate warnings when noSuchMethod is inherited (issue 24337)
==========

[Brian Wilkerson, 2015-10-19 21:16:33]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com

[Brian Wilkerson, 2015-10-19 21:16:34]

If you agree about the co19 tests being wrong I will create an issue for them
and put the number in the status file.

[Paul Berry, 2015-10-19 21:40:10]

I believe this code does the right thing.  However I would feel more comfortable
if two additional corner cases were explicitly tested:

1. noSuchMethod in a mixin should suppress the warning, e.g.:

    class C extends B with M {}
    abstract class B { foo(); }
    class M { noSuchMethod(inv) => null; }

2. noSuchMethod in an interface should NOT suppress the warning, e.g.:

    class C extends B implements I {}
    abstract class B { foo(); }
    class I { noSuchMethod(inv) => null; }

With those two corner cases tested, lgtm.

[Brian Wilkerson, 2015-10-20 17:35:33]

Test cases added.

[Brian Wilkerson, 2015-10-20 17:35:56]

Committed patchset #1 (id:1) manually as
cc8f64b824ac0bd7607ffd330f0b4c287ee25e0f (presubmit successful).