Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1413993006: Remove unused BitmapPlatformDevice::CreateAndClear() (Closed)

Created:
5 years, 1 month ago by tomhudson
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This Cairo-specific function has no callers and no tests. Comments indicate that other backends need equivalent functions, but they seem instead to just take an extra parameter to Create(). Committed: https://crrev.com/5e403c353bbf915425ff2e8b5c37cd11c4b9b8a0 Cr-Commit-Position: refs/heads/master@{#357124}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M skia/ext/bitmap_platform_device_cairo.h View 1 chunk +0 lines, -6 lines 0 comments Download
M skia/ext/bitmap_platform_device_cairo.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Tom Hudson
Another tiny dead code excision.
5 years, 1 month ago (2015-10-27 19:38:18 UTC) #1
robertphillips
lgtm
5 years, 1 month ago (2015-10-30 16:01:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413993006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413993006/1
5 years, 1 month ago (2015-10-30 16:03:16 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 1 month ago (2015-10-30 16:03:17 UTC) #9
f(malita)
lgtm
5 years, 1 month ago (2015-10-30 16:04:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413993006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413993006/1
5 years, 1 month ago (2015-10-30 16:04:20 UTC) #12
f(malita)
On 2015/10/30 16:03:17, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
5 years, 1 month ago (2015-10-30 16:05:13 UTC) #13
tomhudson
On 2015/10/30 16:05:13, f(malita) wrote: > Robert's not a valid skia/ reviewer?! Hopefully just the ...
5 years, 1 month ago (2015-10-30 16:09:11 UTC) #14
robertphillips
On 2015/10/30 16:09:11, tomhudson wrote: > On 2015/10/30 16:05:13, f(malita) wrote: > > Robert's not ...
5 years, 1 month ago (2015-10-30 16:17:03 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 16:48:16 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 16:49:13 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e403c353bbf915425ff2e8b5c37cd11c4b9b8a0
Cr-Commit-Position: refs/heads/master@{#357124}

Powered by Google App Engine
This is Rietveld 408576698