Analysis Options processing task and manager.

Analysis Options processing task and manager.

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/bf0ba96027339f70dce4f1c4d34cb16651b5222d

[pquitslund, 2015-10-20 20:54:04]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[pquitslund, 2015-10-20 20:54:05]

This should get us most of the way to getting `.analysis_options` files setup
for validation.

The next step is to register the work manager and add some tests to verify that
things are wired all the way through.

Suggestions for where best to begin there?  I was planning to start with
`AnalysisOptionsFileNotificationTest` for essentially an integration test.  If
there are other tests you recommend I'm all ears.

Thanks in advance!

[scheglov, 2015-10-20 21:22:20]

LGTM

https://codereview.chromium.org/1413973003/diff/1/pkg/analyzer/lib/src/task/o...
File pkg/analyzer/lib/src/task/options_work_manager.dart (right):

https://codereview.chromium.org/1413973003/diff/1/pkg/analyzer/lib/src/task/o...
pkg/analyzer/lib/src/task/options_work_manager.dart:109: Source htmlSource =
sourceQueue.first;
Rename?

https://codereview.chromium.org/1413973003/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/options_test.dart (right):

https://codereview.chromium.org/1413973003/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/options_test.dart:37: test_buildInputs() {
AFAIK the new style is to not test constructors, inputs, etc.
Just perform().

[pquitslund, 2015-10-20 21:25:54]

Thanks!

https://codereview.chromium.org/1413973003/diff/1/pkg/analyzer/lib/src/task/o...
File pkg/analyzer/lib/src/task/options_work_manager.dart (right):

https://codereview.chromium.org/1413973003/diff/1/pkg/analyzer/lib/src/task/o...
pkg/analyzer/lib/src/task/options_work_manager.dart:109: Source htmlSource =
sourceQueue.first;
On 2015/10/20 21:22:20, scheglov wrote:
> Rename?

Done.

[Brian Wilkerson, 2015-10-20 21:35:40]

LGTM

https://codereview.chromium.org/1413973003/diff/20001/pkg/analyzer/lib/src/ta...
File pkg/analyzer/lib/src/task/options_work_manager.dart (right):

https://codereview.chromium.org/1413973003/diff/20001/pkg/analyzer/lib/src/ta...
pkg/analyzer/lib/src/task/options_work_manager.dart:89: // If analysis is in
progress, combine all known partial results.
Given that there are no partial results to combine, I believe that lines 89-93
could be replaced with
    return AnalysisError.NO_ERRORS;

[pquitslund, 2015-10-20 22:15:20]

Thanks!

https://codereview.chromium.org/1413973003/diff/20001/pkg/analyzer/lib/src/ta...
File pkg/analyzer/lib/src/task/options_work_manager.dart (right):

https://codereview.chromium.org/1413973003/diff/20001/pkg/analyzer/lib/src/ta...
pkg/analyzer/lib/src/task/options_work_manager.dart:89: // If analysis is in
progress, combine all known partial results.
On 2015/10/20 21:35:40, Brian Wilkerson wrote:
> Given that there are no partial results to combine, I believe that lines 89-93
> could be replaced with
>     return AnalysisError.NO_ERRORS;

Good catch.  Fixed.

[pquitslund, 2015-10-20 22:38:59]

Committed patchset #3 (id:40001) manually as
bf0ba96027339f70dce4f1c4d34cb16651b5222d (presubmit successful).