Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 1413953002: Add unit test for SVG path parsing (Closed)

Created:
5 years, 2 months ago by fs
Modified:
5 years, 2 months ago
Reviewers:
pdr.
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add unit test for SVG path parsing This converts svg/dom/path-parser.html into a roughly equivalent unit test. Widen the assert in the SVGPathStringSource constructor to allow "" but not (null) Strings. Also move the non-fuzzed tests from svg/dom/fuzz-path-parser.html. BUG=539385 Committed: https://crrev.com/f47f8d15a10dff0acb74bb105aa514e5faf8612c Cr-Commit-Position: refs/heads/master@{#355008}

Patch Set 1 #

Patch Set 2 : Debug *pfff* #

Patch Set 3 : Widen ASSERT in SVGPathStringSource. #

Patch Set 4 : Moar export. #

Total comments: 1

Patch Set 5 : Drop line-wrap. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -239 lines) Patch
M third_party/WebKit/LayoutTests/svg/dom/fuzz-path-parser.html View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/fuzz-path-parser-expected.txt View 2 chunks +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/path-parser.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/path-parser-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/path-parser-expected.txt View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/dom/script-tests/path-parser.js View 1 chunk +0 lines, -132 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathConsumer.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathParser.h View 1 2 chunks +2 lines, -1 line 0 comments Download
A third_party/WebKit/Source/core/svg/SVGPathParserTest.cpp View 1 2 3 4 1 chunk +121 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathSource.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathStringBuilder.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathStringSource.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathStringSource.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
pdr.
LGTM https://codereview.chromium.org/1413953002/diff/60001/third_party/WebKit/Source/core/svg/SVGPathParserTest.cpp File third_party/WebKit/Source/core/svg/SVGPathParserTest.cpp (right): https://codereview.chromium.org/1413953002/diff/60001/third_party/WebKit/Source/core/svg/SVGPathParserTest.cpp#newcode21 third_party/WebKit/Source/core/svg/SVGPathParserTest.cpp:21: SVGPathStringBuilder builder; \ Nit: \
5 years, 2 months ago (2015-10-19 18:02:23 UTC) #4
fs
On 2015/10/19 at 18:02:23, pdr wrote: > LGTM Damn you're fast! 11 min. before I ...
5 years, 2 months ago (2015-10-19 18:15:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413953002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413953002/80001
5 years, 2 months ago (2015-10-20 08:10:02 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 2 months ago (2015-10-20 08:36:34 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 08:37:28 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f47f8d15a10dff0acb74bb105aa514e5faf8612c
Cr-Commit-Position: refs/heads/master@{#355008}

Powered by Google App Engine
This is Rietveld 408576698