chrome/browser/extensions/api/metrics_private/metrics_private_api.cc - Issue 141393002: Return a NULL histogram pointer on construction error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/metrics_private/metrics_private_api.cc

Issue 141393002: Return a NULL histogram pointer on construction error (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add construction param to restore old CHECK for non-API calls Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/metrics/histogram.h ('K') | « chrome/browser/extensions/api/metrics_private/metrics_apitest.cc ('k') | chrome/test/data/extensions/api_test/metrics/test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/metrics_private/metrics_private_api.cc

diff --git a/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc b/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc

index 89d1d9d40e5c39368124f745031273a9f17d352a..5da645c5e1253b303ac14a452d2714740b4d91bc 100644

--- a/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc

+++ b/chrome/browser/extensions/api/metrics_private/metrics_private_api.cc

@@ -132,11 +132,13 @@ bool MetricsHistogramHelperFunction::RecordValue(

if (type == base::LINEAR_HISTOGRAM) {

counter = base::LinearHistogram::FactoryGet(

name, min, max, buckets,

- base::HistogramBase::kUmaTargetedHistogramFlag);

+ base::HistogramBase::kUmaTargetedHistogramFlag,

+ base::HistogramBase::kAllowBadConstruction);

} else {

counter = base::Histogram::FactoryGet(

name, min, max, buckets,

- base::HistogramBase::kUmaTargetedHistogramFlag);

+ base::HistogramBase::kUmaTargetedHistogramFlag,

+ base::HistogramBase::kAllowBadConstruction);

}

counter->Add(sample);